handle additional cases where rules were getting dropped #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, thanks for keeping this preset updated and publishing to npm!
I've been using this in a project and was having difficulty when trying to use tabs where the input element could control showing/hiding the active content. After digging into this, there are some rules/styles from daisy that seem to be slipping through the cracks as they have a token type of 'type' and resulted in a base defined as an empty string, so they would not get matched by unocss.
The proposed fix is to check for this case and try to define a reasonable base to use, which the implementation finds by scanning the selector for the last class, with the assumption that is the most specific. The specific case I was running into was for the following:
input.tab:checked + .tab-content
When testing, I also noticed that there was another variation of the 'type' case where base was still not getting set, for the drawer component, so i added a check for that as well.
Both of these seem to be handled properly by the test / demo file now.
Thanks again!
-mike